feat: TelemetryLink wait handlers#7164
Open
ozanichkovsky wants to merge 3 commits intostackitcloud:mainfrom
Open
feat: TelemetryLink wait handlers#7164ozanichkovsky wants to merge 3 commits intostackitcloud:mainfrom
ozanichkovsky wants to merge 3 commits intostackitcloud:mainfrom
Conversation
Fyusel
reviewed
May 7, 2026
| @@ -1,5 +1,5 @@ | |||
| ## v0.2.1 | |||
| - **Improvement**: Use new `WaiterHandler` struct in the DNS WaitHandler | |||
| - **Improvement**: Use new `WaiterHandler` struct in the TelemetryRouter WaitHandler | |||
Contributor
There was a problem hiding this comment.
This is the wrong file (telemetrylink instead of router)
| - `telemetrylink`: | ||
| - [v0.1.0](services/telemetrylink/CHANGELOG.md#v010) | ||
| - **New**: API for STACKIT Telemetry Link | ||
| - [v0.1.1](services/telemetryrouter/CHANGELOG.md#v021) |
Contributor
There was a problem hiding this comment.
Same here: telemetrylink and also the version is wrong
| @@ -1,2 +1,5 @@ | |||
| ## v0.2.1 | |||
| createdOrgLink = createResp.Id | ||
|
|
||
| // Wait for the TelemetryLink to be ready | ||
| log.Printf("[TelemetryLink API] Waiting for organization TelemetryLink to be created.\n") |
Contributor
There was a problem hiding this comment.
I would change the wording here. One log above it is said: created and here it is said: waiting for creation.
So I would be confused by looking at those messages during execution: Was it already created or is it still in progress?
| log.Printf("[TelemetryLink API] Updated organization TelemetryLink.\n") | ||
|
|
||
| // Wait for the organization TelemetryLink to be updated | ||
| log.Printf("[TelemetryLink API] Waiting for organization TelemetryLink to be updated.\n") |
| log.Printf("[TelemetryLink API] Partially updated organization TelemetryLink.\n") | ||
|
|
||
| // Wait for the organization TelemetryLink to be partiallyupdated | ||
| log.Printf("[TelemetryLink API] Waiting for organization TelemetryLink to be partially updated.\n") |
| log.Printf("[TelemetryLink API] Organization TelemetryLink \"%s\" has been successfully deleted.\n", createdOrgLink) | ||
|
|
||
| // Wait for the organization TelemetryLink to be deleted | ||
| log.Printf("[TelemetryLink API] Waiting for organization TelemetryLink to be deleted.\n") |
| createdFolderLink = createFolderResp.Id | ||
|
|
||
| // Wait for the Folder TelemetryLink to be ready | ||
| log.Printf("[TelemetryLink API] Waiting for folder TelemetryLink to be created.\n") |
Contributor
There was a problem hiding this comment.
and following, won't comment the other occurrences :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TelemetryLink wait handlers
Checklist
make fmtexamples/directory)make test(will be checked by CI)make lint(will be checked by CI)